Skip to main content

Observable.Timer throws ArgumentOutOfRangeException

We found this one out during testing in different time zones earlier this - if your app is going used in different time zones avoid using DateTime with Observable.Timer. In fact I guess the general message should be avoid DateTime all together in any apps use DateTimeOffset instead...

This code works from here in London but when run in Hong Kong throws an exception:

   1:  static void Main(string[] args)
   2:  {
   3:      var now = DateTimeOffset.Now;
   4:      Console.WriteLine("Time zone offset: " + now.Offset);
   5:   
   6:      var scheduler = NewThreadScheduler.Default;
   7:   
   8:      using(Observable.Timer(DateTime.MinValue, TimeSpan.FromSeconds(1), scheduler)
   9:          .Subscribe(Console.WriteLine))
  10:      {
  11:          Console.ReadLine();
  12:      }            
  13:  }

London time zone shows output as expected:
Where as when run for a time zone set to anything positive of London (offset = 0), e.g. Hong Kong (offset =  +8) you get an exception:
If you want to know why this is happening check out @leeoades post here, but simply because DateTime supports an implicit conversation to DateTimeOffset and the value is invalid after conversation this is why we're seeing this happen.

So it can be fixed easily enough by using any of the following alternatives:

   1:  Observable.Timer(DateTimeOffset.MinValue, TimeSpan.FromSeconds(1));
   2:   
   3:  // or...
   4:   
   5:  Observable.Timer(DateTimeOffset.Now, TimeSpan.FromSeconds(1));
   6:   
   7:  // or...
   8:   
   9:  var scheduler = NewThreadScheduler.Default;
  10:  Observable.Timer(scheduler.Now, TimeSpan.FromSeconds(1), scheduler);

I prefer the final alternative, it's better suited for testing because the scheduler can be mocked out and you can control the value of the Scheduler.Now.

Comments

Popular posts from this blog

Integrating jasmine into Visual Studio 2010/2011 beta

Following on from my previous post about testing javascript with jasmine. I was interested to explore integration into visual studio 2010 so I could run them along side test written in another language like C#. I found the VS 2010 extension Chutpah (pronounced  'hutz-pah'). This got me up and running with the ability to run test manually and to my surprised it worked by only have the SpecRunner.html file open. I didn't a csproj or sln file containing the javascript, it's clever enough to resolve all dependencies: Test results are render in the output window of VS 2010: This is good and I appreciate the work someone has done to get this far but I want more... I want integration into Resharper... A quick squizz on the inter'webs and I end posting a request on jetBrains forum , it looks like support is coming in R# 7. Then I thought lets check out the current beta and see, so off I go and boot Win8 and install R#7 beta and see if it's there yet... ...

Showing a message box from a ViewModel in MVVM

I was doing a code review with a client last week for a WPF app using MVVM and they asked ' How can I show a message from the ViewModel? '. What follows is how I would (and have) solved the problem in the past. When I hear the words ' show a message... ' I instantly think you mean show a transient modal message box that requires the user input before continuing ' with something else ' - once the user has interacted with the message box it will disappear. The following solution only applies to this scenario. The first solution is the easiest but is very wrong from a separation perspective. It violates the ideas behind the Model-View-Controller pattern because it places View concerns inside the ViewModel - the ViewModel now knows about the type of the View and specifically it knows how to show a message box window: The second approach addresses this concern by introducing the idea of messaging\events between the ViewModel and the View. In the example ...

WPF tips & tricks: Dispatcher thread performance

Not blogged for an age, and I received an email last week which provoked me back to life. It was a job spec for a WPF contract where they want help sorting out the performance of their app especially around grids and tabular data. I thought I'd shared some tips & tricks I've picked up along the way, these aren't probably going to solve any issues you might be having directly, but they might point you in the right direction when trying to find and resolve performance issues with a WPF app. First off, performance is something you shouldn't try and improve without evidence, and this means having evidence proving you've improved the performance - before & after metrics for example. Without this you're basically pissing into the wind, which can be fun from a developer point of view but bad for a project :) So, what do I mean by ' Dispatcher thread performance '? The 'dispatcher thread' or the 'UI thread' is probably the most ...